Remove circularity, rootDir errors from node modules compiler tests #62568
+4,860
−4,519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
There was a problem hiding this comment.
Pull Request Overview
This PR removes circular import errors from node modules compiler tests by separating test imports from module declarations. The tests were previously encountering circular definition errors that were blocking TypeScript-go integration, and these circularities weren't essential for testing the intended functionality.
- Split
index.d.tsfiles into separate declaration and test files to eliminate circular imports - Maintained test coverage while removing unnecessary circular dependencies
- Applied consistent pattern across all affected node modules tests
Reviewed Changes
Copilot reviewed 157 out of 157 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/cases/conformance/node/nodeModulesPackagePatternExportsTrailers.ts | Split index.d.ts into separate module declaration and test import files |
| tests/cases/conformance/node/nodeModulesPackagePatternExportsExclude.ts | Applied same pattern to eliminate circular imports while preserving test structure |
| tests/cases/conformance/node/nodeModulesPackagePatternExports.ts | Separated module declarations from import tests to resolve circularity |
| tests/cases/conformance/node/nodeModulesPackageExports.ts | Split imports into test.d.ts files to maintain functionality without circular errors |
| tests/cases/conformance/node/nodeModulesConditionalPackageExports.ts | Applied consistent separation pattern for module declarations and tests |
| tests/cases/conformance/node/allowJs/*.ts | Applied same refactoring pattern to allowJs variants of the tests |
| tests/baselines/reference/* | Updated baseline files reflecting the structural changes and error resolution |
jakebailey
commented
Oct 8, 2025
tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node16).errors.txt
Outdated
Show resolved
Hide resolved
jakebailey
changed the title
andrewbranch
approved these changes
Oct 9, 2025
jakebailey
added a commit
that referenced
this pull request
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks microsoft/typescript-go#1797; the circularities in these tests don't appear to be required to test what the tests need to test. Rather, they were I think just a nice place to test imports of various kinds.
All of the tests were modified in the same way, splitting
index.d.tsfiles like:Into two files:
To both declare a module, but do the import stuff in another place.
I ordered the files in the tests in a way that makes the diffs still try and compare apples-to-apples. so hopefully it shows that the types are still the same (though, sometimes named differently).
Also, drop
rootDirerrors from the tests by setting one manually.